From 6be30bdf2819fae1f30b82ff81419a5a12c45edc Mon Sep 17 00:00:00 2001 From: Juan Quintela Date: Thu, 4 Mar 2010 23:11:38 -0300 Subject: [PATCH 16/42] vl.c: fix warning with _FORTIFY_SOURCE RH-Author: Juan Quintela Message-id: <23cb4fbd9ef3226a52c0158fbca4fbe092b3b8c9.1267743950.git.quintela@redhat.com> Patchwork-id: 7551 O-Subject: [PATCH 16/32] vl.c: fix warning with _FORTIFY_SOURCE Bugzilla: 567099 RH-Acked-by: Kevin Wolf RH-Acked-by: Amit Shah RH-Acked-by: Marcelo Tosatti From: Kirill A. Shutemov CC i386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'main': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:5774: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6064: error: ignoring return value of 'chdir', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6083: error: ignoring return value of 'chdir', declared with attribute warn_unused_result make[1]: *** [vl.o] Error 1 Signed-off-by: Kirill A. Shutemov Signed-off-by: Juan Quintela Signed-off-by: Anthony Liguori (cherry picked from commit dc330e282a9aa2daf1a8703140917a4a2f85397a) Signed-off-by: Juan Quintela --- vl.c | 22 ++++++++++++++++++---- 1 files changed, 18 insertions(+), 4 deletions(-) Signed-off-by: Eduardo Habkost --- vl.c | 22 ++++++++++++++++++---- 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 53162f9..a433f40 100644 --- a/vl.c +++ b/vl.c @@ -3437,11 +3437,17 @@ static int io_thread_fd = -1; static void qemu_event_increment(void) { static const char byte = 0; + ssize_t ret; if (io_thread_fd == -1) return; - write(io_thread_fd, &byte, sizeof(byte)); + ret = write(io_thread_fd, &byte, sizeof(byte)); + if (ret < 0 && (errno != EINTR && errno != EAGAIN)) { + fprintf(stderr, "qemu_event_increment: write() filed: %s\n", + strerror(errno)); + exit (1); + } } static void qemu_event_read(void *opaque) @@ -5898,7 +5904,9 @@ int main(int argc, char **argv, char **envp) if (pid_file && qemu_create_pidfile(pid_file) != 0) { if (daemonize) { uint8_t status = 1; - write(fds[1], &status, 1); + if (write(fds[1], &status, 1) != 1) { + perror("daemonize. Writing to pipe\n"); + } } else fprintf(stderr, "Could not acquire pid file: %s\n", strerror(errno)); exit(1); @@ -6199,7 +6207,10 @@ int main(int argc, char **argv, char **envp) if (len != 1) exit(1); - chdir("/"); + if (chdir("/")) { + perror("not able to chdir to /"); + exit(1); + } TFR(fd = qemu_open("/dev/null", O_RDWR)); if (fd == -1) exit(1); @@ -6218,7 +6229,10 @@ int main(int argc, char **argv, char **envp) fprintf(stderr, "chroot failed\n"); exit(1); } - chdir("/"); + if (chdir("/")) { + perror("not able to chdir to /"); + exit(1); + } } if (run_as) { -- 1.6.3.rc4.29.g8146