From 346d7e3dae071222d8d0bbdfd265c125c74cb0c2 Mon Sep 17 00:00:00 2001 From: Juan Quintela Date: Thu, 4 Mar 2010 23:11:46 -0300 Subject: [PATCH 24/42] slirp: check system() success RH-Author: Juan Quintela Message-id: Patchwork-id: 7552 O-Subject: [PATCH 24/32] slirp: check system() success Bugzilla: 567099 RH-Acked-by: Kevin Wolf RH-Acked-by: Amit Shah RH-Acked-by: Marcelo Tosatti we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Signed-off-by: Eduardo Habkost --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b75ad16..e19a664 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -469,7 +469,7 @@ static void slirp_smb_cleanup(SlirpState *s) if (s->smb_dir[0] != '\0') { snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir); ret = system(cmd); - if (!WIFEXITED(ret)) { + if (ret == -1 || !WIFEXITED(ret)) { qemu_error("'%s' failed.\n", cmd); } else if (WEXITSTATUS(ret)) { qemu_error("'%s' failed. Error code: %d\n", -- 1.6.3.rc4.29.g8146